fix: edge case fixes based on codemod application#30
Merged
valerybugakov merged 1 commit intomainfrom Sep 23, 2021
Merged
Conversation
vovakulikov
reviewed
Sep 22, 2021
| while (!areAllNodesProcessed) { | ||
| // `processNodesWithClassName` returns `true` when there's nothing more to process. | ||
| areAllNodesProcessed = processNodesWithClassName({ | ||
| usageStats, |
There was a problem hiding this comment.
I really like this idea about usage stats and reporting thing, Cool!
vovakulikov
reviewed
Sep 22, 2021
| nextNode.replaceWith(parse(nextNodeValue.replace('__', '.'))) | ||
|
|
||
| return true | ||
| /** |
vovakulikov
approved these changes
Sep 22, 2021
vovakulikov
left a comment
vovakulikov
left a comment
There was a problem hiding this comment.
I didn't test that manually but unit tests look good.
Member
Author
|
Thanks, Vova! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes added in process code-modding the main Sourcegraph repo with
globalCssToCssModulecodemod.Changes
classNamescall in React component.classNamesprops: e.g.,contentClassName.exportName: e.g.,registryExtensionButton->button.;after last rule in the root CSS class.